[Telemetry] Add eventlog endpoint for collecting client-side events #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump telemetry extension commit as well
Experiments here informed the schema naming recommendations in jupyter/telemetry#11
python 3.5 is still supported
This lets us add detailed documentation & description to our schemas, which is very hard to do in JSON. We also add a lot of documentation to the one JSON schema we have
Primary advantage over JSON is that we can do multi-line strings for more detailed documentation. We also expect humans to read & write these, so YAML is a much better format there. All JSON is also valid YAML, so that helps. Depends on jupyter/telemetry#13
We made a v0.0.1 release!
for client event schema files .suffix is not included in importlib.resources APIs and so might not always work
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 77.73% 77.64% -0.09%
==========================================
Files 106 108 +2
Lines 9288 9412 +124
Branches 1001 1018 +17
==========================================
+ Hits 7220 7308 +88
- Misses 1710 1745 +35
- Partials 358 359 +1
Continue to review full report at Codecov.
|
kevin-bates
reviewed
May 3, 2021
Zsailer
changed the title
Zsailer
changed the title
Zsailer
changed the title
Zsailer
added
the
Telemetry
5 tasks
|
This work has been superceded by #862. Closing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for client telemetry events. originally from #364, moved to a separate PR here after discussion at jupyter-server/team-compass#4.
need to be in sync with #364 and cannot be merged before #364 is merged and jupyter/telemetry#62 is resolved.