Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry] Add eventlog endpoint for collecting client-side events #501

Closed
wants to merge 52 commits into from
Closed

[Telemetry] Add eventlog endpoint for collecting client-side events #501

wants to merge 52 commits into from

Commits on May 19, 2020

  1. Add initial eventlog hook

    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    344bb57 View commit details
    Browse the repository at this point in the history

  2. Install jupyter_telemetry from source

    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    a0f40ea View commit details
    Browse the repository at this point in the history

  3. Set up an eventlog API endpoint 

    Bump telemetry extension commit as well
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    96bf2f0 View commit details
    Browse the repository at this point in the history

  4. Use different naming convention & add test for it 

    Experiments here informed the schema naming
recommendations in jupyter/telemetry#11
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    06b91e0 View commit details
    Browse the repository at this point in the history

  5. Don't use f-strings 

    python 3.5 is still supported
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    716ff1b View commit details
    Browse the repository at this point in the history

  6. Derive JSON Schema files from YAML files 

    This lets us add detailed documentation & description
to our schemas, which is very hard to do in JSON.

We also add a lot of documentation to the one
JSON schema we have
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    8e122fc View commit details
    Browse the repository at this point in the history

  7. Keep event schemas in YAML 

    Primary advantage over JSON is that we can do multi-line strings
for more detailed documentation. We also expect humans to read &
write these, so YAML is a much better format there. All JSON
is also valid YAML, so that helps.

Depends on jupyter/telemetry#13
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    f9a0dfb View commit details
    Browse the repository at this point in the history

  8. Depend on the jupyter_telemetry package 

    We made a v0.0.1 release!
    @yuvipanda @Zsailer
    yuvipanda authored and Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    c7428e8 View commit details
    Browse the repository at this point in the history

  9. read schemas from new utils function

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    9437e88 View commit details
    Browse the repository at this point in the history

  10. Add fix for tables in RTD theme sphinx docs. 

    Solution came from https://rackerlabs.github.io/docs-rackspace/tools/rtd-tables.html
    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    6e3c80c View commit details
    Browse the repository at this point in the history

  11. add event schema auto-documentation to jupyter notebook docs

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    4035fd5 View commit details
    Browse the repository at this point in the history

  12. format paths in recorded events

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    23d50a3 View commit details
    Browse the repository at this point in the history

  13. add documentation for eventlog endpoint

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    3c94970 View commit details
    Browse the repository at this point in the history

  14. return exception as 400 error in eventlog endpoint

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    e76c91b View commit details
    Browse the repository at this point in the history

  15. normalize path in emitted event

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    2ce7c54 View commit details
    Browse the repository at this point in the history

  16. initial tests

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5794d31 View commit details
    Browse the repository at this point in the history

  17. add initial telemetry docs

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    7c9d3d5 View commit details
    Browse the repository at this point in the history

  18. fix jupyter_telemetry dependency

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    ef8573d View commit details
    Browse the repository at this point in the history

  19. point telemetry at correct dev branch

    @Zsailer
    Zsailer committed May 19, 2020
    Configuration menu
    Copy the full SHA
    ea9e352 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. add tests for eventlog

    @kiendang
    kiendang committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b06f7d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Merge branch 'master' into jupyter_telemetry

    @kiendang
    kiendang committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4d7fc23 View commit details
    Browse the repository at this point in the history

  2. Use correct fixture names

    @kiendang
    kiendang committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    7302396 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Merge branch 'master' into jupyter_telemetry

    @kiendang
    kiendang committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    2c79b1a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Fix import

    @kiendang
    kiendang committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0ac16dc View commit details
    Browse the repository at this point in the history

  2. Remove redundant call

    @kiendang
    kiendang committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    7c81b23 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Update telemetry

    @kiendang
    kiendang committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    b8ca484 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Add note about security

    @kiendang
    kiendang committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ac452cd View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Register client telemetry schemas using entry_points

    @kiendang
    kiendang committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    70f9275 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Add working telemetry commit for testing

    @kiendang
    kiendang committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    7f50c85 View commit details
    Browse the repository at this point in the history

  2. Use backported importlib_metadata

    @kiendang
    kiendang committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    99439b6 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into jupyter_telemetry

    @kiendang
    kiendang committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    cdc92e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Ignore errors while registering client events

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8e69ab0 View commit details
    Browse the repository at this point in the history

  2. Add client eventlog to list services

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e2db0ad View commit details
    Browse the repository at this point in the history

  3. Add tests for client telemetry events

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    66accdc View commit details
    Browse the repository at this point in the history

  4. Add client telemetry eventlog tests to CI

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4dcd258 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into jupyter_telemetry

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    87dca57 View commit details
    Browse the repository at this point in the history

  6. Clean up

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9fd2a5f View commit details
    Browse the repository at this point in the history

  7. Fix eventlog test

    @kiendang
    kiendang committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f692488 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Use standard lib instead of backport when possible

    @kiendang
    kiendang committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    21117a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. Fix docs

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    1936503 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jupyter_telemetry

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    e099ccc View commit details
    Browse the repository at this point in the history

  3. Fix docs

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    bc94f13 View commit details
    Browse the repository at this point in the history

  4. Refine example

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    bfbdd17 View commit details
    Browse the repository at this point in the history

  5. Use same interface for registering file and file object

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    0974231 View commit details
    Browse the repository at this point in the history

  6. Fix client test ci

    @kiendang
    kiendang committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    035eb6e View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Remove redundant check

    @kiendang
    kiendang committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    8179c47 View commit details
    Browse the repository at this point in the history

  2. Add docs on registering client events

    @kiendang
    kiendang committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    c307a8d View commit details
    Browse the repository at this point in the history

  3. Remove unrelated doc change

    @kiendang
    kiendang committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    e206188 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Add .yml extension

    @kiendang
    kiendang committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cce5c71 View commit details
    Browse the repository at this point in the history

  2. No longer use pathlib .suffix to check file extension 

    for client event schema files
.suffix is not included in importlib.resources APIs and so might not always work
    @kiendang
    kiendang committed May 3, 2021
    Configuration menu
    Copy the full SHA
    19214e8 View commit details
    Browse the repository at this point in the history

  3. Doc change notebook server to jupyter server

    @kiendang
    kiendang committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c67401d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into telemetry_client

    @kiendang
    kiendang committed May 3, 2021
    Configuration menu
    Copy the full SHA
    e15dd9b View commit details
    Browse the repository at this point in the history