Minimal updates for draft-04 interop with moq-rs #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Definitely open to help from others on this, btw.) |
10 tasks
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
6cd52c6
to
12ff3d3
Compare
This parses fine, but I don't love nesting the start/end values here and I wonder if it might be better to accept a tiny bit more complexity in the encoder so we can use undefined instead of `0` to denote cases where we haven't set these values. Leaning towards yes...
|
This is able to play back streams published and relayed by kixelated/moq-rs#172 but it still needs some cleanup. It looks like I missed some updates on the publish side, too, so I'll fix that up before marking as ready for review. |
englishm
commented
Aug 7, 2024
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
12ff3d3
to
eb9e06b
Compare
I do like using the language from the spec, but given the start/end positions are nested within this, Location seems a better name for now.
englishm
changed the title
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
f7dc3a3
to
5fa8cf0
Compare
englishm
commented
Aug 9, 2024
kixelated
reviewed
Aug 12, 2024
Incorporate @kixelated's feedback from: kixelated#107 (comment)
Incorporates feedback from @kixelated: kixelated#107 (comment)
kixelated
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need at least minimal wire image parsing support in order to merge kixelated/moq-rs#172 without breaking the quic.video demo site.
Not planning to implement everything in one go here, just enough to get keep the demos running for now.