Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to draft-04 #172

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Conversation

englishm
Copy link
Collaborator

@englishm englishm commented Jun 17, 2024

Update moq-rs to draft-04

Checklist (PRs to spec between -03 and -04 tags):

  • 405 ContentExists alignment (already matches existing implementation)

  • Changes that impact the Subscribe message wire format:

  • Object Status

    • 429 Add object status used to indicate lost or nonexistent objects
  • Track Status

    • 425 Add a way to get the current group ID
      • Track Status Request
      • Track Status
  • 435 SUBSCRIBE_UPDATE

    • 457 Add a message code for SUBSCRIBE_UPDATE

For a few things here, implementations are only partial (full handling isn't always implemented, and not every new feature is exposed to library consumers), but this should cover at least all of the wire image changes so that basic interop can be achieved.

@englishm englishm self-assigned this Jun 17, 2024
@englishm englishm force-pushed the me/draft-ietf-moq-transport-04 branch 2 times, most recently from 86d316e to 42d57dd Compare June 18, 2024 20:48
@englishm englishm force-pushed the me/draft-ietf-moq-transport-04 branch 4 times, most recently from f790275 to 90ba70c Compare June 29, 2024 06:47
@englishm englishm force-pushed the me/draft-ietf-moq-transport-04 branch from d456610 to 9d6186e Compare July 25, 2024 06:53
@englishm englishm marked this pull request as ready for review July 25, 2024 07:27
@englishm englishm requested a review from kixelated July 25, 2024 07:27
@englishm englishm changed the title WIP: draft-04 updates Update to draft-04 Jul 25, 2024
@englishm englishm mentioned this pull request Jul 25, 2024
Copy link
Owner

@kixelated kixelated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta update moq-js at least to add ObjectStatus before we can merge.

@englishm
Copy link
Collaborator Author

Yep, this is just blocked on kixelated/moq-js#107 and a minor rebase/cleanup to deal with version bumps that landed on main since I last touched this.

@englishm englishm force-pushed the me/draft-ietf-moq-transport-04 branch from 66f0f81 to 74fe3e7 Compare August 6, 2024 05:39
Not trying for any backwards compatibility here, will just roll forward
to the latest draft.
Serialization/Deserialization for this new message type in moq-transport

https://www.ietf.org/archive/id/draft-ietf-moq-transport-04.html#message-track-status-req

Introduced in moq-wg/moq-transport#425

Note: Does not include any handling for this message type yet
Serialization/Deserialization for this new message type in moq-transport

https://www.ietf.org/archive/id/draft-ietf-moq-transport-04.html#section-6.17

Introduced in moq-wg/moq-transport#425

Note: Does not include any handling for this message type yet, nor any
validation of status codes
We don't _do_ anything with this information yet, but now we can at
least parse it.
Set up publisher sessions to respond to track status requests
Parsing for this mesage type, but not handling (yet)

Uses code from moq-wg/moq-transport#457 since it
was missed in draft-04.
cargo semver-checks flagged moq-transport, but also bump binaries for
wire image compatibility
@englishm englishm force-pushed the me/draft-ietf-moq-transport-04 branch from b51425e to f8a4ecb Compare August 9, 2024 05:21
@kixelated kixelated merged commit 27ef650 into kixelated:main Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants