Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: update Node capacity by profile #1612

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

fix NodeHandle for ElasticQuotaProfile

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 31.14% and project coverage change: +0.11% 🎉

Comparison is base (199e650) 64.70% compared to head (f474cca) 64.81%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
+ Coverage   64.70%   64.81%   +0.11%     
==========================================
  Files         361      361              
  Lines       37636    37696      +60     
==========================================
+ Hits        24351    24434      +83     
+ Misses      11493    11474      -19     
+ Partials     1792     1788       -4     
Flag Coverage Δ
unittests 64.81% <31.14%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...r/plugins/elasticquota/core/group_quota_manager.go 69.75% <2.32%> (-3.22%) ⬇️
pkg/scheduler/plugins/elasticquota/node_handler.go 61.53% <100.00%> (+11.53%) ⬆️
.../scheduler/plugins/elasticquota/profile_handler.go 61.11% <100.00%> (+5.55%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title fix NodeHandle for ElasticQuotaProfile koord-scheduler: fix NodeHandle for ElasticQuotaProfile Sep 4, 2023
@shaloulcy shaloulcy mentioned this pull request Sep 4, 2023
8 tasks
@eahydra eahydra changed the title koord-scheduler: fix NodeHandle for ElasticQuotaProfile koord-scheduler: update Node capacity by profile Sep 4, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8a0142b into koordinator-sh:main Sep 4, 2023
19 checks passed
@shaloulcy
Copy link
Contributor Author

shaloulcy commented Sep 18, 2023

#1621

ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants