feat(js-api): add types for Editor Config Contributor client extension #1185
Conversation
markocikos
force-pushed
the
LPS-204054
branch
from
dded3b6
to
50938f3
Compare
|
@izaera I force pushed changes, please take a look. In addition, do you know what causes the |
markocikos
changed the title
markocikos
changed the title
Looks like an internal issue in GH actions. I'd rerun it again. |
.github/workflows/labeler.yml
Outdated
| on: | ||
| - pull_request_target | ||
| pull_request_target: |
There was a problem hiding this comment.
This is what is making the CI task fail, right?
There was a problem hiding this comment.
No, it still failed after that 😞 I'm trying to figure out what's going on, currently my best guess is that the latest version of https://github.com/actions/labeler requires different configuration.
There was a problem hiding this comment.
OK, I think I have this figured out:
- Check is failing because v5 introduced new format for paths. Our version is currently set to
main, which worked fine until two weeks ago when v5 released. - Check is still failing when I make the version fixed in PR, because it is still running actions/labeler@main
@izaera Any objections to merge the chore commit that sets version fixed to v4?
There was a problem hiding this comment.
🤷 I've never touched that part. If it works, push it 😅
There was a problem hiding this comment.
I think there is no way for me to know, before merging. It'll be fine, I'm sure
There was a problem hiding this comment.
Leaving a note for @bryceosterhaus here. Setting of version from main to v4 fixes the labeler issue, but I'm not sure if it goes again some wider dependencies convention in this repo. If yes, then we can spend a bit of time updating configuration format to the latest version.
|
LGTM! |
markocikos
force-pushed
the
LPS-204054
branch
3 times, most recently
from
007130f
to
2f632fb
Compare
markocikos
force-pushed
the
LPS-204054
branch
from
2f632fb
to
888223f
Compare
|
@izaera Can you release new version of @liferay/js-api? I can try, but I'm not sure if I have permissions, or if there are and hidden quirks of this repo. |
|
let me check 👍 |
|
It's as explained here -> https://github.com/liferay/liferay-frontend-projects/blob/master/projects/js-toolkit/CONTRIBUTING.md I'll try it now bc it's been long since I don't release a version of this project, but IIRC there's nothing special with this project. Only that we are releasing pre-versions until we decide to make it effective and start to maintain proper versioning of the contracts. |
|
There you go -> https://github.com/liferay/liferay-frontend-projects/releases/tag/js-api%2Fv0.6.0-pre.0 Next time you simply need to run the steps described in CONTRIBUTING.md. As for the permissions, you should be fine because we set all our npm packages to the same user group (liferay devs), so you should have permissions too. |
References
What is the goal of this PR?
Adding public types for Editor Config Contributor client extension.
Notes:
EditorConfigTransformerand notEditorConfigContributor. We plan to add a different CET in the future, that will not use the JavaEditorConfigContributorframework in DXP. That CET will still be able to use this API, as both will do the same config transformation in the end.[key: string]: any;for config structure. This is based on the third-party APIs and is likely to change with time. Being so generic will also enable us to be consistent with APIs for CKEditor 5 or other editors. I added in commited docs link to offical docs for theconfigobject.