dev #1519
Merged
dev #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baywet
commented
Feb 21, 2024
baywet
commented
- chore(deps): bump dawidd6/action-download-artifact from 3.1.0 to 3.1.1
- Added a test for the completion of a file content update via LargeFileUploadTask
- Fixed test and fixed a bug
- Test fix and updating releases
- - fixes implementation difference for large file upload session
- - reverts status code changes
- - code linting
- - fixes NRP in large file upload
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](dawidd6/action-download-artifact@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…s/dawidd6/action-download-artifact-3.1.1 chore(deps): bump dawidd6/action-download-artifact from 3.1.0 to 3.1.1
The test UploadResponseHandlerTest#getUploadSessionOnProgressingUpload mimicked a server response with a 200/OK response code. In the REST reference (https://learn.microsoft.com/en-us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0#upload-bytes-to-the-upload-session) it is stated that the response code for uploading more bytes to the upload session is 202/Accepted. The bug in #1517 is fixed. Previously the method UploadResponseHandler#handleResponse handled differently the response in these two cases: - response code 200/OK - all other cases Now the same method handles differently the response in these two cases: - response code 200/OK or 201/Created - all other cases Everything works if the REST reference is corrected and: - 200/OK is returned when an item is updated, 201/Created is returned when an item is Created - 202/Accepted is returned when more bytes are requested
- Updated the patch version in gradle.properies - Updated changelog.md and readme.md with the new patch version - Bumped kiota dependencies to 1.0.3 - Fixed the test UploadSliceRequestTest.putReturnsExpectedUploadSession which did not respect the response descripted in the REST reference
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Fix for issue 1517 and correction of two tests not respecting the REST reference (impacted by the fix)
|
andrueastman
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.