Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #1519

Merged
merged 10 commits into from
Feb 22, 2024
Merged

dev #1519

merged 10 commits into from
Feb 22, 2024

Commits on Feb 19, 2024

  1. chore(deps): bump dawidd6/action-download-artifact from 3.1.0 to 3.1.1

    Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3.1.0 to 3.1.1.
    - [Release notes](https://github.com/dawidd6/action-download-artifact/releases)
    - [Commits](dawidd6/action-download-artifact@v3.1.0...v3.1.1)
    
    ---
    updated-dependencies:
    - dependency-name: dawidd6/action-download-artifact
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4020b30 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1516 from microsoftgraph/dependabot/github_action…

    …s/dawidd6/action-download-artifact-3.1.1
    
    chore(deps): bump dawidd6/action-download-artifact from 3.1.0 to 3.1.1
    github-actions[bot] authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dde3ec2 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    2c168c7 View commit details
    Browse the repository at this point in the history
  2. Fixed test and fixed a bug

    The test UploadResponseHandlerTest#getUploadSessionOnProgressingUpload mimicked a server response with a 200/OK response code.
    In the REST reference (https://learn.microsoft.com/en-us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0#upload-bytes-to-the-upload-session) it is stated that the response code for uploading more bytes to the upload session is 202/Accepted.
    The bug in #1517 is fixed.
    Previously the method UploadResponseHandler#handleResponse handled differently the response in these two cases:
    - response code 200/OK
    - all other cases
    
    Now the same method handles differently the response in these two cases:
    - response code 200/OK or 201/Created
    - all other cases
    
    Everything works if the REST reference is corrected and:
    - 200/OK is returned when an item is updated, 201/Created is returned when an item is Created
    - 202/Accepted is returned when more bytes are requested
    kekolab committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dc45304 View commit details
    Browse the repository at this point in the history
  3. Test fix and updating releases

    - Updated the patch version in gradle.properies
    - Updated changelog.md and readme.md with the new patch version
    - Bumped kiota dependencies to 1.0.3
    - Fixed the test UploadSliceRequestTest.putReturnsExpectedUploadSession which did not respect the response descripted in the REST reference
    kekolab committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2c1684d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3be4c4b View commit details
    Browse the repository at this point in the history
  5. - reverts status code changes

    baywet committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3482361 View commit details
    Browse the repository at this point in the history
  6. - code linting

    Signed-off-by: Vincent Biret <[email protected]>
    baywet committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4cb7c3b View commit details
    Browse the repository at this point in the history
  7. - fixes NRP in large file upload

    Signed-off-by: Vincent Biret <[email protected]>
    baywet committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9d368ce View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1518 from kekolab/dev

    Fix for issue 1517 and correction of two tests not respecting the REST reference (impacted by the fix)
    baywet authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    93ea88a View commit details
    Browse the repository at this point in the history