Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting issue with napalm/base/validate.py:165:10 E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance() [pycodestyle] #1984

Closed
jsenecal opened this issue Aug 1, 2023 · 0 comments · Fixed by #1985

Comments

@jsenecal
Copy link
Contributor

jsenecal commented Aug 1, 2023

Last working build

Collecting pycodestyle (from flake8-import-order==0.18.2->-r requirements-dev.txt (line 4))
  Downloading pycodestyle-2.10.0-py2.py3-none-any.whl (41 kB)

failing build

Collecting pycodestyle (from flake8-import-order==0.18.2->-r requirements-dev.txt (line 4))
  Obtaining dependency information for pycodestyle from https://files.pythonhosted.org/packages/31/c2/e1508ed4395793f69e40fd8c6b5a690e1d568e649aae9492076a7b6befb4/pycodestyle-2.11.0-py2.py3-none-any.whl.metadata
  Downloading pycodestyle-2.11.0-py2.py3-none-any.whl.metadata (4.5 kB)

Guessing we have a new linting rule in pycodestyle 2.11

Originally posted by @bewing in #1983 (comment)

Will provide a fix shortly - please assign this one to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant