Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junos: Do not try to parse a "none" value and convert it to "" for get_ipv6_neighbors_table #1983

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

jsenecal
Copy link
Contributor

Fixes #1978

@jsenecal
Copy link
Contributor Author

Failing test is not related to my changes.

@jsenecal
Copy link
Contributor Author

jsenecal commented Aug 1, 2023

Hi @bewing ,
Would you happen to know why this fails on an unrelated test ?

@bewing
Copy link
Member

bewing commented Aug 1, 2023

Last working build

Collecting pycodestyle (from flake8-import-order==0.18.2->-r requirements-dev.txt (line 4))
  Downloading pycodestyle-2.10.0-py2.py3-none-any.whl (41 kB)

failing build

Collecting pycodestyle (from flake8-import-order==0.18.2->-r requirements-dev.txt (line 4))
  Obtaining dependency information for pycodestyle from https://files.pythonhosted.org/packages/31/c2/e1508ed4395793f69e40fd8c6b5a690e1d568e649aae9492076a7b6befb4/pycodestyle-2.11.0-py2.py3-none-any.whl.metadata
  Downloading pycodestyle-2.11.0-py2.py3-none-any.whl.metadata (4.5 kB)

Guessing we have a new linting rule in pycodestyle 2.11

@jsenecal
Copy link
Contributor Author

jsenecal commented Aug 1, 2023

Issue and fix for the linting error : #1984 @bewing

@bewing
Copy link
Member

bewing commented Aug 1, 2023

@jsenecal can you leave the "normal" test as-is and create a new folder with a new test in it (named iss1978 or similar), with its own inputs and expected result?

@jsenecal
Copy link
Contributor Author

jsenecal commented Aug 1, 2023

@jsenecal can you leave the "normal" test as-is and create a new folder with a new test in it (named iss1978 or similar), with its own inputs and expected result?

Done.

Copy link
Member

@bewing bewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but otherwise LGTM

@bewing bewing merged commit d0097a1 into napalm-automation:develop Aug 1, 2023
6 checks passed
@bewing
Copy link
Member

bewing commented Aug 1, 2023

Thanks for your contribution!

@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NAPALM w/junos driver fails to properly identify/sanitize the output of junos_views.junos_ipv6_neighbors_table
3 participants