Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLD: API for number-text and date-text table columns #1268

Merged
merged 30 commits into from
Jun 15, 2023

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented May 23, 2023

Pull Request

🀨 Rationale

Need APIs for #1011 and #1014. Builds on #1224.

πŸ‘©β€πŸ’» Implementation

Updates to existing HLD. Philosophy is to rely on the browser's Intl formatting APIs when possible and to provide modes with opinionanted configuration and with custom configuration.

πŸ§ͺ Testing

N/A

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI marked this pull request as ready for review May 23, 2023 21:03
Copy link
Contributor

@msmithNI msmithNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. Approving but assuming these updates will be made:

  • removing locale from API, and instead stating it'll be looked up from lang/locale on the theme provider
  • placeholder being shown for date columns when the value is null

@jattasNI
Copy link
Contributor Author

@mollykreis @atmgrifter00 @rajsite heads up that I've responded to the last open comment threads so this is ready for your next round of review.

@jattasNI jattasNI enabled auto-merge (squash) June 15, 2023 14:42
@jattasNI jattasNI merged commit 838f14b into main Jun 15, 2023
@jattasNI jattasNI deleted the users/jattas/intl-table-columns-hld branch June 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants