Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show changeset element counts using badges #4872

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show changeset element counts using badges #4872

wants to merge 2 commits into from
+24 −18

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Jun 3, 2024 •
edited
Loading

We use counter badges in other places. We can use them on changeset pages in element headings instead of numbers in ().

Before/after:
image image

@AntonKhorev AntonKhorev added the changesets Related to the Changesets feature label Jul 3, 2024
@AntonKhorev AntonKhorev mentioned this pull request Jul 24, 2024
Open
nenad-vujicic
nenad-vujicic suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great, thanks for it! Requires updating with the latest changes of _paging_nav.html.erb / en.yml.

@AntonKhorev AntonKhorev force-pushed the element-count-badge branch 2 times, most recently from 4b59d74 to 30d7f92 Compare August 29, 2024 14:01
@AntonKhorev
Copy link
Collaborator Author

rebased

nenad-vujicic
nenad-vujicic approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and works perfectly now, thank you very much!

@AntonKhorev AntonKhorev mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenad-vujicic nenad-vujicic nenad-vujicic approved these changes

Assignees
No one assigned
Labels
changesets Related to the Changesets feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonKhorev @nenad-vujicic