Fix windows only build failure on include filename. #17721
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_679703637
branch
13 times, most recently
from
31d4f9e
to
1ce7a49
Compare
Between eliding third_party directory names in includes, and Windows being case insensitive on header include paths, the following include was ambiguous and resolved to (1), leading to issues in using the StableHLO header: ``` #include "stablehlo/transforms/Passes.h" // (1) tensorflow/compiler/mlir/lite/stablehlo/transforms/passes.h // (2) @stablehlo - third_party/stablehlo/stablehlo/transforms/Passes.h ``` PiperOrigin-RevId: 679703637
copybara-service
bot
force-pushed
the
test_679703637
branch
from
1ce7a49
to
c9fdf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix windows only build failure on include filename.
Between eliding third_party directory names in includes, and Windows being case insensitive on header include paths, the following include was ambiguous and resolved to (1), leading to issues in using the StableHLO header: