-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kermalis mega clean numero2 #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we use structs
versus sticking it in global.h
like pokeemerald/pokefirered? Speed? Trying to understand the reasoning.
AnonymousRandomPerson
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work from my previous PR, I did these things:
EWRAM_DATA
/EWRAM_DATA_2
/IWRAM_DATA
and mark up file boundariesThis PR also tackled the massive block of strings that I call
common_strings
. It has some stuff used in most menus like "Info" or "Yes". For some reason, it also includes the dialogue for all the shops and the hints. It's pretty weird but that's what they did so I moved all of that out of data and now we have a simple#include "common_strings.h"
instead of definingextern const *gCommonInfo[];
etc in dozens of files.Also did some charmap work where it was needed
There's probably more I'm forgetting. I decomp'd some functions also, but only like 5 if I had to guess.
So here's stuff that needs to be finished in my next PR: