Cleanup config files

[n-rodriguez]

This PR remove white spaces in plugins config files.

[myii]

@n-rodriguez I've done a brief eyeball check and this looks like a significant and excellent contribution. The only comment I have is regarding the use of Jinja whitespace control, specifically doubling up the -, i.e. {%- ... -%}. References:

• Issue raised: jinja strip white spaces option in salt master config causes a broken pg_hba.conf postgres-formula#241
• Resolved by: Edit pg_hba template to work with jinja 'trim whitespaces' option on salt master postgres-formula#244
• Upstream issue: jinja_trim_blocks and jinja_lstrip_blocks Seem to Break Formulas saltstack/salt#35398
  • This issue was closed but was reopened after some discussions
• Another issue: Remove blank lines in rendered ssh_config and sshd_config openssh-formula#148

Basically, as a rough guideline to minimise formula breakages, limit whitespace control to only a single -, usually {%- ... %}.

[n-rodriguez]

Basically, as a rough guideline to minimise formula breakages, limit whitespace control to only a single -, usually {%- ... %}.

Yes, I understand this kind of concern, but actually the '-' I added are here to remove empty lines at the top of files. The goal was to trim whitespaces so I was very careful to not change the logic implemented.

[myii]

@n-rodriguez I fully understand. Have you tried setting the following in your master config?

# Old version:
# jinja_trim_blocks: True

# New version:
jinja_env:
  trim_blocks: True

I was amazed at how aggressive this is! I spent a fair while with this when arguing things in the upstream issue and I found it broke (and I mean broke) so many formulas. I've asked for this to be improved, where we can override this setting as formula writers, but until then we're going to have to be cautious about "excessive" whitespace control.

Ultimately, it's your PR and this is only a general suggestion, nothing enforced.

[n-rodriguez]

Fixed!

[myii]

@n-rodriguez Just the last ones that slipped through... after these, I'll leave you alone, promise!

[n-rodriguez]

done

[myii]

@n-rodriguez Thanks for going to a lot of effort to clean up these files. From my part, I'm satisfied that this is a worthy PR. I'm approving this based on my eyeball review. Due to my lack of familiarity with this formula itself, I'll leave it to the others to dissect the actual impact of the changes.