Migrate most JavaScript code to Stimulus controllers #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, @elia! That's a great improvement for the experience with solidus starer frontend!
I left a question about the locale controller. Besides, I didn't manually test that all the behaviour remains in place, but I'm sure you did 🙂
Other than that, what do you think about splitting the work into different PRs? That would make reviewing and future references easier.
| %> | ||
|
|
||
| <ul class="<%= class_names %>"> | ||
| <ul class="products-grid"> |
| @@ -0,0 +1,7 @@ | |||
| import { Controller } from "@hotwired/stimulus" | |||
|
|
|||
| export default class extends Controller { | |||
There was a problem hiding this comment.
I think I'm missing something. Where is this controller used? 🤔
Both the "primary" and "disabled" classes are not used anywhere in the CSS.
Allows better control and reuse for the address, and prepares for having the stimulus controller on the fieldset itself.
The CSS wasn't about inputs, but about the address step.
Added missing `const` declarations.
Mimic Stimulus controller and prepare for an easier migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: