Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate most JavaScript code to Stimulus controllers #340

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Migrate most JavaScript code to Stimulus controllers #340

wants to merge 16 commits into from

Commits on Jun 13, 2023

  1. Turn the locale selector into a stimulus controller

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    59402f6 View commit details
    Browse the repository at this point in the history

  2. Fetch the cart link from the top-bar stimulus controller

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b9580c4 View commit details
    Browse the repository at this point in the history

  3. Move cart.js to a stimulus controller

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7dc15e7 View commit details
    Browse the repository at this point in the history

  4. Remove unused function

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    5bb6392 View commit details
    Browse the repository at this point in the history

  5. Inline smaller product selection helpers

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6d66702 View commit details
    Browse the repository at this point in the history

  6. Extract Solidus.disableSaveOnClick to a stimulus controller 

    Both the "primary" and "disabled" classes are not used anywhere in the
CSS.
    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    55dd27e View commit details
    Browse the repository at this point in the history

  7. Move the ToS check to the checkout stimulus controller

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d2d68dd View commit details
    Browse the repository at this point in the history

  8. Add erb-formatter to the bundle

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f7f440f View commit details
    Browse the repository at this point in the history

  9. Move the address fieldset element inside the partial 

    Allows better control and reuse for the address, and prepares
for having the stimulus controller on the fieldset itself.
    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    5504e04 View commit details
    Browse the repository at this point in the history

  10. Move address JavaScript to a stimulus controller

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a86efb2 View commit details
    Browse the repository at this point in the history

  11. Embed the address-input style into the address step 

    The CSS wasn't about inputs, but about the address step.
    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    54e76fa View commit details
    Browse the repository at this point in the history

  12. Sync templates to the sandbox before starting dev mode

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2484ec4 View commit details
    Browse the repository at this point in the history

  13. Replace static content_tag with plain HTML

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6932809 View commit details
    Browse the repository at this point in the history

  14. Fix and reformat product page JavaScript 

    Added missing `const` declarations.
    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7c71e0d View commit details
    Browse the repository at this point in the history

  15. Refactor the Product JavaScript into a class 

    Mimic Stimulus controller and prepare for an easier migration.
    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    bd52565 View commit details
    Browse the repository at this point in the history

  16. elia/stimulus: [wip]

    @elia
    elia committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7d4d100 View commit details
    Browse the repository at this point in the history