Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use caching and split Build and Tests step #112

Merged
merged 9 commits into from
Oct 2, 2024
Merged

CI: use caching and split Build and Tests step #112

merged 9 commits into from
Oct 2, 2024

Conversation

abeatrix
Copy link
Collaborator

@abeatrix abeatrix commented Oct 1, 2024 •
edited
Loading

@abeatrix abeatrix changed the title use buildDebug CI: use caching and split Build and Tests step Oct 1, 2024
@abeatrix abeatrix mentioned this pull request Oct 2, 2024
Closed
tomaszgolebiowski
tomaszgolebiowski approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@tomaszgolebiowski tomaszgolebiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More and more commands are being executed in github actions. I'm starting to wonder whether to abandon cake.build altogether in favor of github actions.

abeatrix
abeatrix commented Oct 2, 2024
View reviewed changes
.github/workflows/cake-build.yml
cd src
dotnet cake --target=BuildDebug

- name: Tests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiotrKarczmarz @tomaszgolebiowski i noticed it's the Tests task that's usually take some time to start, but can't reproduce locally. Is this because of the infrastructure issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this is because the CI infra is quite slow, and initial waiting time for registering extension and starting VS takes a lot of much time.

PiotrKarczmarz
PiotrKarczmarz approved these changes Oct 2, 2024
View reviewed changes
.github/workflows/cake-build.yml
cd src
dotnet cake --target=BuildDebug

- name: Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this is because the CI infra is quite slow, and initial waiting time for registering extension and starting VS takes a lot of much time.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Test Results

10 tests  ±0   10 ✅ ±0   2m 39s ⏱️ - 3m 7s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e70af49. ± Comparison against base commit f8de4cc.

@abeatrix
Copy link
Collaborator Author

abeatrix commented Oct 2, 2024

Test Results

10 tests  ±0   10 ✅ ±0   2m 39s ⏱️ - 3m 7s  1 suites ±0    0 💤 ±0   1 files   ±0    0 ❌ ±0 

Results for commit e70af49. ± Comparison against base commit f8de4cc.

haha super cool! @PiotrKarczmarz

@abeatrix abeatrix merged commit 57697d1 into main Oct 2, 2024
3 checks passed
@abeatrix abeatrix deleted the bee/cache-ci branch October 2, 2024 13:15
@PiotrKarczmarz
Copy link
Collaborator

The build time is ridiculously fast now. Thanks a lot @abeatrix with helping with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrKarczmarz PiotrKarczmarz PiotrKarczmarz approved these changes

@tomaszgolebiowski tomaszgolebiowski tomaszgolebiowski approved these changes

@BolajiOlajide BolajiOlajide Awaiting requested review from BolajiOlajide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abeatrix @PiotrKarczmarz @tomaszgolebiowski