Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use caching and split Build and Tests step #112

Merged
merged 9 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 68 additions & 41 deletions .github/workflows/cake-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,51 +2,78 @@

on:
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]
workflow_dispatch:

# concurrency prevents multiple instances of the workflow from running at the same time,
# using `cancel-in-progress` to cancel any existing runs.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build:
runs-on: windows-latest
# this now uses a dedicated large runner from GitHub running the following specs:
# 8-core, 32GB RAM, 300GB SSD
# https://github.com/organizations/sourcegraph/settings/actions/runner-groups/6
runs-on: 16gb_16_core_large_window_runner
# do we want to run this on forks?
if: github.repository_owner == 'sourcegraph'

steps:
- uses: actions/checkout@v3

- name: Add msbuild to PATH
uses: microsoft/[email protected]

- name: ⚙️ Prepare Visual Studio
run: '&"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.exe" /RootSuffix Exp /ResetSettings General.vssettings'

- name: Install Cake.Tool
run: dotnet tool install --global Cake.Tool

- name: Restore NuGet packages
run: nuget restore src\Cody.Core\Cody.Core.csproj -PackagesDirectory src\packages

- name: Build Release
run: |
cd src
dotnet tool restore
corepack enable
corepack install --global [email protected]
dotnet cake

- name: Tests
env:
Access_Token_UI_Tests: ${{ secrets.SRC_ACCESS_TOKEN_DOTCOM }}
run: |
cd src
dotnet cake --target Tests
dotnet test .\Cody.VisualStudio.Tests\bin\Debug\Cody.VisualStudio.Tests.dll -v detailed -l:trx

- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action/windows@v2
if: always()
with:
files: |
src\TestResults/**/*.xml
src\TestResults/**/*.trx
src\TestResults/**/*.json
- uses: actions/checkout@v3

- name: Add msbuild to PATH
uses: microsoft/[email protected]

- name: ⚙️ Prepare Visual Studio
run: '&"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.exe" /RootSuffix Exp /ResetSettings General.vssettings'

- name: Install Cake.Tool
run: dotnet tool install --global Cake.Tool

- name: Restore NuGet packages
run: nuget restore src\Cody.Core\Cody.Core.csproj -PackagesDirectory src\packages

- name: Common Build Setup
run: |
cd src
dotnet tool restore
corepack enable

- name: Build Cody Agent if needed
run: |
cd src
corepack install --global [email protected]
dotnet cake --target=BuildCodyAgentIfNeeded

- name: Cache cody-dist
uses: actions/cache@v3
with:
path: cody-dist/agent
key: ${{ runner.os }}-cody-dist-${{ github.sha }}
restore-keys: |
${{ runner.os }}-cody-dist-

- name: Build Extension (Debug)
run: |
cd src
dotnet cake --target=BuildDebug

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiotrKarczmarz @tomaszgolebiowski i noticed it's the Tests task that's usually take some time to start, but can't reproduce locally. Is this because of the infrastructure issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this is because the CI infra is quite slow, and initial waiting time for registering extension and starting VS takes a lot of much time.

- name: Tests
env:
Access_Token_UI_Tests: ${{ secrets.SRC_ACCESS_TOKEN_DOTCOM }}
run: |
cd src
dotnet test .\Cody.VisualStudio.Tests\bin\Debug\Cody.VisualStudio.Tests.dll -v detailed -l:trx

- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action/windows@v2
if: always()
with:
files: |
src\TestResults/**/*.xml
src\TestResults/**/*.trx
src\TestResults/**/*.json
27 changes: 27 additions & 0 deletions src/build.cake
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,20 @@ Task("BuildCodyAgent")

});

Task("BuildCodyAgentIfNeeded")
.Does(() =>
{
if (!DirectoryExists(codyDir) || !DirectoryExists(agentDir))
{
Information("Cody Agent dist directory not found. Building Cody Agent...");
RunTarget("BuildCodyAgent");
}
else
{
Information("Cody Agent dist directory already exists. Skipping build.");
}
});

Task("DownloadNode")
.Does(() =>
{
Expand Down Expand Up @@ -181,6 +195,19 @@ Task("Build")
});
});

Task("BuildDebug")
.IsDependentOn("DownloadNode")
.IsDependentOn("Restore")
.Does(() =>
{
MSBuild("./Cody.sln", new MSBuildSettings
{
Configuration = "Debug",
PlatformTarget = PlatformTarget.MSIL,
Verbosity = Verbosity.Minimal
});
});

Task("Tests")
//.IsDependentOn("Build")
.Does(() =>
Expand Down
Loading