Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module CPC calculation #1127

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

btian1
Copy link
Contributor

@btian1 btian1 commented Nov 13, 2023

Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar, after internal technical
discussion, change module CPC to the product of maximum value
of module's cpu_peak and the margin scalar, and change the margin
scalar to 1.1 as aligned.

@btian1 btian1 requested a review from a team as a code owner November 13, 2023 03:41
@aiChaoSONG
Copy link

aiChaoSONG commented Nov 13, 2023

Still use CPC_MARGIN? if so, change the commit message accordingly, please. Can you also explain why the Margin is 1.1 now with a comment?

@btian1
Copy link
Contributor Author

btian1 commented Nov 13, 2023

Still use CPC_MARGIN? if so, change the commit message accordingly, please. Can you also explain why the Margin is 1.1 now with a comment?

both Pierre and Liam are suggesting use a CPC margin, Liam suggested more with 10%, so I add 10% as margin.

@btian1
Copy link
Contributor Author

btian1 commented Nov 15, 2023

@marc-hb @aiChaoSONG , could you check and review this PR?

@aiChaoSONG
Copy link

code looks good, suggested commit message:

commit title: tools: sof_perf_analyzer: change module CPC calculation, audio: perf is meaningless, this part is used to point where the code is, or the file you changed.
commit msg:

Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar, after internal technical
discussion, change module CPC to the product of maximum value
of module's cpu_peak and the margin scalar, and change the margin
scalar to 1.1 as aligned.

@btian1 btian1 changed the title audio: perf: change module CPC calculation Change module CPC calculation Nov 15, 2023
Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar, after internal technical
discussion, change module CPC to the product of maximum value
of module's cpu_peak and the margin scalar, and change the margin
scalar to 1.1 as aligned.

Signed-off-by: Baofeng Tian <[email protected]>
@btian1
Copy link
Contributor Author

btian1 commented Nov 16, 2023

code looks good, suggested commit message:

commit title: tools: sof_perf_analyzer: change module CPC calculation, audio: perf is meaningless, this part is used to point where the code is, or the file you changed. commit msg:

Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar, after internal technical
discussion, change module CPC to the product of maximum value
of module's cpu_peak and the margin scalar, and change the margin
scalar to 1.1 as aligned.

all changed, please check again.

@aiChaoSONG
Copy link

quite simple change, merge now

@aiChaoSONG aiChaoSONG merged commit 6063785 into thesofproject:main Nov 16, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants