-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change module CPC calculation #1127
Conversation
1a8f8ec
to
ae09a3d
Compare
Still use CPC_MARGIN? if so, change the commit message accordingly, please. Can you also explain why the Margin is 1.1 now with a comment? |
ae09a3d
to
83c15af
Compare
both Pierre and Liam are suggesting use a CPC margin, Liam suggested more with 10%, so I add 10% as margin. |
@marc-hb @aiChaoSONG , could you check and review this PR? |
code looks good, suggested commit message: commit title:
|
83c15af
to
f7636b6
Compare
Previously, module CPC is calculated by multiplying the mean value of cpu_peak with a margin scalar, after internal technical discussion, change module CPC to the product of maximum value of module's cpu_peak and the margin scalar, and change the margin scalar to 1.1 as aligned. Signed-off-by: Baofeng Tian <[email protected]>
all changed, please check again. |
quite simple change, merge now |
Previously, module CPC is calculated by multiplying the mean
value of cpu_peak with a margin scalar, after internal technical
discussion, change module CPC to the product of maximum value
of module's cpu_peak and the margin scalar, and change the margin
scalar to 1.1 as aligned.