Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make start_test() optional: part 1 #1170

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 5, 2024

@marc-hb marc-hb marked this pull request as ready for review April 5, 2024 21:59
@marc-hb marc-hb requested a review from a team as a code owner April 5, 2024 21:59
@marc-hb marc-hb requested a review from ujfalusi April 5, 2024 22:00
@marc-hb marc-hb marked this pull request as draft April 6, 2024 00:05
@marc-hb

This comment was marked as resolved.

@marc-hb

This comment was marked as outdated.

Extract new playback_subtest() function to de-duplicate. Pure clean-up,
zero functional change.

Signed-off-by: Marc Herbert <[email protected]>
Extract new print_test_result_exit() function from exit handler(). This
make it possible for some "light-weight" tests like
verify-kernel-boot-log.sh to not depend on the heavy and start_test()
and exit handler machinery.

Signed-off-by: Marc Herbert <[email protected]>
This unblocks thesofproject#1170 and allows "installing" the func_exit_handler() trap
in start_test() which will allow making start_test() optional.

Signed-off-by: Marc Herbert <[email protected]>
func_exit_handler() makes sense only when used with start_test()

start_test() is a "mandatory" right now because it's invoked from
lib.sh. But this is wrong because it should be possible to import lib.sh
functions without actually running anything and it's causing various
issues like sof_remove.sh depending on the firmware being loaded, see
discussion in thesofproject#1169

This commit will make it possible NOT to use start_test().

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb marked this pull request as ready for review April 18, 2024 22:12
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 18, 2024

Copy link
Collaborator

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good starting point as part 1.
Looking forward to seeing part 2

@fredoh9
Copy link
Collaborator

fredoh9 commented Apr 19, 2024

SOFCI TEST

@fredoh9
Copy link
Collaborator

fredoh9 commented Apr 19, 2024

The device test is triggered to test lnl pr test

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 20, 2024

There's no DSP runtime PM on ba-lnlm-rvp-hda-01 https://sof-ci.01.org/softestpr/PR1170/build320/devicetest/index.html?model=LNLM_RVP_HDA&testcase=check-runtime-pm-status

I just reproduced even without this PR, so it's unrelated. Merging.

@marc-hb marc-hb merged commit c058fcf into thesofproject:main Apr 20, 2024
4 of 7 checks passed
marc-hb added a commit that referenced this pull request Apr 20, 2024
This unblocks #1170 and allows "installing" the func_exit_handler() trap
in start_test() which will allow making start_test() optional.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb deleted the opt-start-test-1 branch April 20, 2024 18:07
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 20, 2024

That's because /sys/devices/pci0000:00/0000:00:1f.3/power/control is on on that ba-lnlm-rvp-hda-01 device instead of auto on other devices. Even after a reboot. Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants