alsa_settings: MTLP_RVP_SDW.sh: add rt711 GE control #1206
Conversation
|
MTL https://sof-ci.01.org/softestpr/PR1206/build523/devicetest/index.html all green but there's no MTLP_RVP_SDW model in PR testing, only in daily test runs. CAVS25 https://sof-ci.01.org/softestpr/PR1206/build522/devicetest/index.html is totally empty. cc: |
| @@ -1,5 +1,9 @@ | |||
| set -e | |||
|
|
|||
| # override jack detection mode to headset | |||
| # related linux pr: https://github.com/thesofproject/linux/pull/4969 | |||
| amixer -c sofsoundwire cset name='rt711 GE49 Selected Mode' 2 || true | |||
There was a problem hiding this comment.
I just realized that this is a copy/paste of 90e0929 in LNLM_SDW_AIOC.sh
Can you please add a duplication warning at the top of the file? Something short and generic, no need to go into a detailed comparison about what is copied from LNLM_SDW_AIOC versus what has diverged. Something like: # A lot of this file is duplicated in LNLM_SDW_AIOC.sh and possibly others.
Also add the same warning at the top of LNLM_SDW_AIOC.sh, which will avoid future commits like 90e0929 missing the duplication and forgetting to update some files.
There was a problem hiding this comment.
I just realized that this is a copy/paste of 90e0929 in
LNLM_SDW_AIOC.shCan you please add a duplication warning at the top of the file? Something short and generic, no need to go into a detailed comparison about what is copied from
LNLM_SDW_AIOCversus what has diverged. Something like:# A lot of this file is duplicated in LNLM_SDW_AIOC.sh and possibly others.Also add the same warning at the top of
LNLM_SDW_AIOC.sh, which will avoid future commits like 90e0929 missing the duplication and forgetting to update some files.
Done
|
SOFCI TEST |
https://sof-ci.01.org/softestpr/PR1206/build528/devicetest/index.html has 2 models out of 3. I guess CI was just busy. |
MTLP_RVP_SDW uese rt711 and it needs to overwritre the jack detection type. Signed-off-by: Bard Liao <[email protected]>
MTLP_RVP_SDW uese rt711 and it needs to overwritre the jack detection type.