Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alsa_settings: MTLP_RVP_SDW.sh: add rt711 GE control #1206

Merged
merged 1 commit into from
Jun 20, 2024
Merged

alsa_settings: MTLP_RVP_SDW.sh: add rt711 GE control #1206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions alsa_settings/MTLP_RVP_SDW.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
#This file is duplicated to MTLP_SDW_AIOC.sh since we only set rt711 mixer
#controls for the AIOC board.

set -e

# override jack detection mode to headset
# related linux pr: https://github.com/thesofproject/linux/pull/4969
amixer -c sofsoundwire cset name='rt711 GE49 Selected Mode' 2 || true
Copy link
Collaborator

@marc-hb marc-hb Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this is a copy/paste of 90e0929 in LNLM_SDW_AIOC.sh

Can you please add a duplication warning at the top of the file? Something short and generic, no need to go into a detailed comparison about what is copied from LNLM_SDW_AIOC versus what has diverged. Something like: # A lot of this file is duplicated in LNLM_SDW_AIOC.sh and possibly others.

Also add the same warning at the top of LNLM_SDW_AIOC.sh, which will avoid future commits like 90e0929 missing the duplication and forgetting to update some files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this is a copy/paste of 90e0929 in LNLM_SDW_AIOC.sh

Can you please add a duplication warning at the top of the file? Something short and generic, no need to go into a detailed comparison about what is copied from LNLM_SDW_AIOC versus what has diverged. Something like: # A lot of this file is duplicated in LNLM_SDW_AIOC.sh and possibly others.

Also add the same warning at the top of LNLM_SDW_AIOC.sh, which will avoid future commits like 90e0929 missing the duplication and forgetting to update some files.

Done


# enable headset playback
amixer -c sofsoundwire cset name='Headphone Switch' on
amixer -c sofsoundwire cset name='rt711 FU05 Playback Volume' 80
Expand Down
Loading