Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow amazon as a platform #1824

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Allow amazon as a platform #1824

merged 1 commit into from
Oct 2, 2023

Conversation

yachub
Copy link
Contributor

@yachub yachub commented Sep 25, 2023

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ddb181) 74.55% compared to head (d7b7d75) 74.58%.
Report is 1 commits behind head on master.

❗ Current head d7b7d75 differs from pull request most recent head 403a511. Consider uploading reports for the commit 403a511 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
+ Coverage   74.55%   74.58%   +0.03%     
==========================================
  Files          81       81              
  Lines        4508     4510       +2     
==========================================
+ Hits         3361     3364       +3     
+ Misses       1147     1146       -1     
Files Coverage Δ
lib/beaker/host/unix/exec.rb 72.13% <ø> (ø)
lib/beaker/host/unix/file.rb 90.90% <ø> (ø)
lib/beaker/host/unix/pkg.rb 52.38% <100.00%> (ø)
lib/beaker/host_prebuilt_steps.rb 74.03% <100.00%> (+0.59%) ⬆️
lib/beaker/platform.rb 100.00% <100.00%> (ø)
lib/beaker/perf.rb 56.66% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/beaker/host/unix/exec.rb Outdated Show resolved Hide resolved
@yachub
Copy link
Contributor Author

yachub commented Sep 26, 2023

@ekohl and @bastelfreak based on the comments, does it seem good for now?

@yachub yachub merged commit 4a7b068 into voxpupuli:master Oct 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants