Skip to content
Compliance Checks

drivers: spi: RPi Pico PIO SPI code size and byte order. #152145

Sign in to view logs

drivers: spi: RPi Pico PIO SPI code size and byte order.

drivers: spi: RPi Pico PIO SPI code size and byte order. #152145

Triggered via pull request September 30, 2024 15:24
@ThreeEightsThreeEights
synchronize #74117
ThreeEights:spi-rpi-pico-pio-endian
Status Success
Total duration 3m 23s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
3m 14s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 4 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - /* .wrap_target */ - 0x6001, /* 0: out pins, 1 side 0 */ - 0xb042, /* 1: nop side 1 */ - /* .wrap */ + /* .wrap_target */ + 0x6001, /* 0: out pins, 1 side 0 */ + 0xb042, /* 1: nop side 1 */ + /* .wrap */ File:drivers/spi/spi_rpi_pico_pio.c Line:103 You may want to run clang-format on this change: - /* .wrap_target */ - 0x6020, /* 0: out x, 32 side 0 */ - 0x5001, /* 1: in pins, 1 side 1 */ - 0x0041, /* 2: jmp x--, 1 side 0 */ - /* .wrap */ + /* .wrap_target */ + 0x6020, /* 0: out x, 32 side 0 */ + 0x5001, /* 1: in pins, 1 side 1 */ + 0x0041, /* 2: jmp x--, 1 side 0 */ + /* .wrap */ File:drivers/spi/spi_rpi_pico_pio.c Line:120 You may want to run clang-format on this change: - return ((data->pio->sm[data->pio_sm].addr == data->pio_tx_offset) - && pio_sm_is_tx_fifo_empty(data->pio, data->pio_sm)); + return ((data->pio->sm[data->pio_sm].addr == data->pio_tx_offset) && + pio_sm_is_tx_fifo_empty(data->pio, data->pio_sm)); File:drivers/spi/spi_rpi_pico_pio.c Line:196 You may want to run clang-format on this change: - data->tx_period_ticks = DIV_ROUND_UP(CONFIG_SYS_CLOCK_TICKS_PER_SEC, - spi_cfg->frequency); + data->tx_period_ticks = + DIV_ROUND_UP(CONFIG_SYS_CLOCK_TICKS_PER_SEC, spi_cfg->frequency); data->pio_tx_offset = pio_add_program(data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_tx)); - data->pio_rx_offset = pio_add_program( - data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_rx)); + data->pio_rx_offset = + pio_add_program(data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_rx)); data->pio_rx_wrap_target = - data->pio_rx_offset + - RPI_PICO_PIO_GET_WRAP_TARGET(spi_sio_mode_0_0_rx); - data->pio_rx_wrap = data->pio_rx_offset + - RPI_PICO_PIO_GET_WRAP(spi_sio_mode_0_0_rx); + data->pio_rx_offset + RPI_PICO_PIO_GET_WRAP_TARGET(spi_sio_mode_0_0_rx); + data->pio_rx_wrap = + data->pio_rx_offset + RPI_PICO_PIO_GET_WRAP(spi_sio_mode_0_0_rx); File:drivers/spi/spi_rpi_pico_pio.c Line:320
You may want to run clang-format on this change: drivers/spi/spi_rpi_pico_pio.c#L103
drivers/spi/spi_rpi_pico_pio.c:103 - /* .wrap_target */ - 0x6001, /* 0: out pins, 1 side 0 */ - 0xb042, /* 1: nop side 1 */ - /* .wrap */ + /* .wrap_target */ + 0x6001, /* 0: out pins, 1 side 0 */ + 0xb042, /* 1: nop side 1 */ + /* .wrap */
You may want to run clang-format on this change: drivers/spi/spi_rpi_pico_pio.c#L120
drivers/spi/spi_rpi_pico_pio.c:120 - /* .wrap_target */ - 0x6020, /* 0: out x, 32 side 0 */ - 0x5001, /* 1: in pins, 1 side 1 */ - 0x0041, /* 2: jmp x--, 1 side 0 */ - /* .wrap */ + /* .wrap_target */ + 0x6020, /* 0: out x, 32 side 0 */ + 0x5001, /* 1: in pins, 1 side 1 */ + 0x0041, /* 2: jmp x--, 1 side 0 */ + /* .wrap */
You may want to run clang-format on this change: drivers/spi/spi_rpi_pico_pio.c#L196
drivers/spi/spi_rpi_pico_pio.c:196 - return ((data->pio->sm[data->pio_sm].addr == data->pio_tx_offset) - && pio_sm_is_tx_fifo_empty(data->pio, data->pio_sm)); + return ((data->pio->sm[data->pio_sm].addr == data->pio_tx_offset) && + pio_sm_is_tx_fifo_empty(data->pio, data->pio_sm));
You may want to run clang-format on this change: drivers/spi/spi_rpi_pico_pio.c#L320
drivers/spi/spi_rpi_pico_pio.c:320 - data->tx_period_ticks = DIV_ROUND_UP(CONFIG_SYS_CLOCK_TICKS_PER_SEC, - spi_cfg->frequency); + data->tx_period_ticks = + DIV_ROUND_UP(CONFIG_SYS_CLOCK_TICKS_PER_SEC, spi_cfg->frequency); data->pio_tx_offset = pio_add_program(data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_tx)); - data->pio_rx_offset = pio_add_program( - data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_rx)); + data->pio_rx_offset = + pio_add_program(data->pio, RPI_PICO_PIO_GET_PROGRAM(spi_sio_mode_0_0_rx)); data->pio_rx_wrap_target = - data->pio_rx_offset + - RPI_PICO_PIO_GET_WRAP_TARGET(spi_sio_mode_0_0_rx); - data->pio_rx_wrap = data->pio_rx_offset + - RPI_PICO_PIO_GET_WRAP(spi_sio_mode_0_0_rx); + data->pio_rx_offset + RPI_PICO_PIO_GET_WRAP_TARGET(spi_sio_mode_0_0_rx); + data->pio_rx_wrap = + data->pio_rx_offset + RPI_PICO_PIO_GET_WRAP(spi_sio_mode_0_0_rx);

Artifacts

Produced during runtime
Name Size
compliance.xml
1.1 KB