Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: update quota and pod handle for elasticquotaprofile #1621

Merged

Conversation

shaloulcy
Copy link
Contributor

@shaloulcy shaloulcy commented Sep 6, 2023

Ⅰ. Describe what this PR does

update quota and pod handle for elasticquotaprofile

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@shaloulcy shaloulcy mentioned this pull request Sep 4, 2023
8 tasks
@eahydra eahydra changed the title [koord-scheduler] update quota and pod handle for elasticquotaprofile koord-scheduler: update quota and pod handle for elasticquotaprofile Sep 6, 2023
@eahydra eahydra changed the title koord-scheduler: update quota and pod handle for elasticquotaprofile koord-scheduler: update quota and pod handle for elasticquotaprofile Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 69.95% and project coverage change: +0.11% 🎉

Comparison is base (4c1cfb3) 65.68% compared to head (4d8b28f) 65.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   65.68%   65.79%   +0.11%     
==========================================
  Files         374      373       -1     
  Lines       39106    39263     +157     
==========================================
+ Hits        25686    25833     +147     
+ Misses      11561    11560       -1     
- Partials     1859     1870      +11     
Flag Coverage Δ
unittests 65.79% <69.95%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/scheduler/plugins/elasticquota/node_handler.go 50.00% <ø> (-11.54%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 75.47% <26.08%> (+5.72%) ⬆️
pkg/scheduler/plugins/elasticquota/pod_handler.go 46.77% <47.72%> (-17.52%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 49.05% <55.55%> (-2.40%) ⬇️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 75.00% <64.51%> (-8.02%) ⬇️
pkg/webhook/elasticquota/quota_topology.go 73.68% <70.00%> (+1.49%) ⬆️
pkg/scheduler/plugins/elasticquota/plugin.go 58.79% <70.27%> (-4.40%) ⬇️
...kg/scheduler/plugins/elasticquota/quota_handler.go 75.53% <76.28%> (-0.03%) ⬇️
pkg/quota-controller/profile/profile_controller.go 65.16% <76.47%> (+4.83%) ⬆️
...duler/plugins/elasticquota/quota_overuse_revoke.go 71.67% <80.76%> (+0.41%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/XXL and removed size/XL labels Sep 7, 2023
@hormes
Copy link
Member

hormes commented Sep 7, 2023

/lgtm

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 8, 2023
@shaloulcy shaloulcy force-pushed the on_quota_handle_for_profile branch 3 times, most recently from 1984ff6 to cf60ab2 Compare September 9, 2023 01:34
@hormes
Copy link
Member

hormes commented Sep 11, 2023

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Sep 11, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 483e429 into koordinator-sh:main Sep 11, 2023
19 checks passed
@shaloulcy
Copy link
Contributor Author

#1606

ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants