-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update models with adaptation mechanisms and change tag 'adaptive threshold' to 'adaptation' #3241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones included seem right. I noted one that is missing. The "Izhikevich" model can present spike frequency adaptation.
@shimoura I don't see, however, an obvious parameter that reflects an adaptive mechanism in the model code |
The model is similar to aeif category. The main difference is the dependence of membrane voltage with quadratic terms instead of exponential. And the parameters "a", "b", and "d" are in some way similar to the parameters "a" and "b" of aeif models. Obs: I noticed in Izhikevich documentation that du/dt should be dU_m/dt to match the variable names. |
thanks for the explanation, Izhikevich is now added |
Merging with 1 reviewer, since it's documentation related, also discussed in person at NEST meeting, to general approval of concept |
This PR updates the model tag for models that use an adaptation mechanism to 'adaptation' after discussions with @ddahmen
The reason is that not all the models have the same adaptation mechanism, and the ones labeled with adaptive threshold (i.e. 'aeif' models) technically do not have an adaptive threshold.
We were also missing tags for several models that have an adaptation mechanism but were not 'aeif' models.
See Read the Docs output here: https://nest-simulator--3241.org.readthedocs.build/en/3241/models/index.html#adaptation
@shimoura agreed to review, thanks!